[LG-5721] chore: Validation Cleanup #3299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bb8db5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 96 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
adamrasheed
requested review from
a team,
stephl3 and
tsck
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs validation cleanup to address warnings from the pnpm command. The changes focus on removing unused dependencies and reorganizing package classifications between production dependencies and devDependencies.
Key Changes:
- Removed unused dependencies across 40+ packages (e.g.,
xml2json,@lg-tools/test, various UI component cross-references) - Moved test-only and development-only dependencies to
devDependencies(e.g.,lodash,polished,@lg-tools/test-harnesses) - Updated dependency versions:
globfrom10.3.12to^11.0.0,@eslint/compatfrom^1.2.3to^1.2.4
Reviewed Changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/validate/package.json | Removed unused @lg-tools/test from devDependencies |
| tools/test/package.json | Moved @lg-tools/build and @lg-tools/meta to devDependencies as they're only used for building the test package itself |
| tools/storybook-addon/package.json | Removed 11 unused polyfill and utility packages |
| tools/lint/package.json | Updated @eslint/compat to newer version ^1.2.4 |
| tools/link/package.json | Removed unused @lg-tools/test from devDependencies |
| tools/eslint-plugin/package.json | Moved lodash to devDependencies and removed unused @lg-tools/test |
| tools/build/package.json | Updated glob from 10.3.12 to ^11.0.0 |
| packages/vertical-stepper/package.json | Moved @leafygreen-ui/button to devDependencies; removed @lg-tools/build and @lg-tools/storybook-utils (build tools available at root) |
| packages/toolbar/package.json | Removed unused @leafygreen-ui/hooks; moved test dependencies to devDependencies |
| packages/text-area/package.json | Removed unused @leafygreen-ui/icon and @leafygreen-ui/palette |
| packages/tabs/package.json | Moved @lg-tools/test-harnesses to devDependencies; added missing dev dependencies |
| packages/table/package.json | Reorganized dependencies, moving test/dev packages from dependencies to devDependencies |
| packages/split-button/package.json | Removed unused @leafygreen-ui/tokens |
| packages/side-nav/package.json | Added @floating-ui/react to devDependencies |
| packages/section-nav/package.json | Added @lg-tools/build to devDependencies |
| packages/search-input/package.json | Removed unused polished |
| packages/radio-box-group/package.json | Moved @leafygreen-ui/lib to devDependencies |
| packages/progress-bar/package.json | Moved polished from devDependencies to dependencies |
| packages/popover/package.json | Added typography and polished to devDependencies |
| packages/modal/package.json | Added development dependencies used in tests |
| packages/menu/package.json | Moved lodash and polished to devDependencies; removed unused @leafygreen-ui/text-input |
| packages/logo/package.json | Removed unused @leafygreen-ui/lib |
| packages/loading-indicator/package.json | Moved @lg-tools/test-harnesses to devDependencies |
| packages/input-option/package.json | Removed unused @leafygreen-ui/icon from devDependencies |
| packages/inline-definition/package.json | Removed unused @leafygreen-ui/tokens |
| packages/icon/package.json | Removed unused xml2json |
| packages/gallery-indicator/package.json | Moved @lg-tools/test-harnesses to devDependencies |
| packages/form-footer/package.json | Moved polished to devDependencies |
| packages/form-field/package.json | Added polished to devDependencies |
| packages/feature-walls/package.json | Removed unused @lg-tools/build |
| packages/drawer/package.json | Reorganized dependencies, moving unused/test packages appropriately |
| packages/descendants/package.json | Added polished and @floating-ui/react to devDependencies |
| packages/date-utils/package.json | Moved test utilities (lodash, timezone-mock) to devDependencies |
| packages/code/package.json | Reorganized dependencies, moving test tools to devDependencies |
| packages/code-editor/package.json | Moved test harnesses and prettier to devDependencies |
| packages/callout/package.json | Moved icon and code-related dev dependencies appropriately |
| packages/a11y/package.json | Removed unused @leafygreen-ui/lib |
| chat/message-feed/package.json | Moved message-related dependencies to devDependencies |
| chat/fixed-chat-window/package.json | Added dev dependencies for syntax highlighting and utilities |
| chat/chat-window/package.json | Reorganized dependencies for dev/test usage |
| chat/chat-layout/package.json | Moved test harnesses to devDependencies; added missing dev dependencies |
| charts/legend/package.json | Added dev dependencies for drag-and-drop and charting |
| pnpm-lock.yaml | Lock file updated to reflect all dependency changes |
| .changeset/five-bags-carry.md | Changeset documenting the cleanup for all affected packages |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Contributor
|
Size Change: +17.7 kB (+0.98%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
Contributor
|
Coverage after merging ar/LG-5721 into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
This PR addresses the warnings produced by the
pnpm command. It is mostly removing unused packages, and moving certain packages to devDependancies if they're only used for unit tests🎟 Jira ticket: https://jira.mongodb.org/browse/LG-5721
✅ Checklist
For new components
For bug fixes, new features & breaking changes
pnpm changesetand documented my changes🧪 How to test changes