LG-4881: fix expanded rows with no sub-rows #2714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 84aa510 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kraenhansen
force-pushed
the
kh/table/fix-expanded-content-rows
branch
from
879b55a to
84aa510
Compare
|
Size Change: -25 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
shaneeza
reviewed
Feb 10, 2025
| @@ -35,7 +35,6 @@ const InternalRowWithRT = <T extends LGRowData>({ | |||
|
|
|||
| const isExpandable = row.getCanExpand(); | |||
| const depth = row.depth; | |||
| const hasSubRows = row.subRows.length > 0; | |||
There was a problem hiding this comment.
This is intentional; check out this chat from another PR. When expanded content is open, the parent row should not be highlighted.
There was a problem hiding this comment.
It feels strange to me that there is a need to differentiate extended content from sub-rows here. Are there any deeper thoughts to that decision?
It was found as a regression when reviewing my PR upgrading to the latest LG and as it wasn't explicitly called out as a change in the packages/table/UPGRADE.md doc, I assumed this was a bug.
There was a problem hiding this comment.
Apologies for not adding it to the upgrade guide. I'll update it. It was missing from the initial implementation, and we caught it during the refactor.
11 tasks
|
Closing as this is working as designed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Merging this PR will:
isExpandedunconditionally.🎟 Jira ticket: LG-4881
✅ Checklist
For bug fixes, new features & breaking changes
pnpm changesetand documented my changesFor new components
🧪 How to test changes