Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add atlas-operator chart flag for creating Role and RoleBinding #331

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

danielcoman
Copy link
Contributor

Closes #330

All Submissions:

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@s-urbaniak
Copy link
Collaborator

s-urbaniak commented Jul 2, 2024

Proof PR was green, this is LGTM, just looking for one more pair of eyes @igor-karpukhin @helderjs @josvazg @roothorp @dan-mckean before we merge.

Copy link
Collaborator

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@s-urbaniak
Copy link
Collaborator

@danielcoman thank you so much for the contribution! Merging 💪 🚢

@s-urbaniak s-urbaniak merged commit 5babc47 into mongodb:main Jul 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

atlas-operator chart install requires cluster admin role when using watchNamespaces
5 participants