-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[community-operator Hem chart] Add very useful values for pod scheduling #329
base: main
Are you sure you want to change the base?
Conversation
…SpreadConstraints
Supersedes #248 Anyone to review this? |
This PR is being marked stale because it has been open for 60 days with no activity. Please update the PR or ask for a fresh review. |
Is it possible to get a review? |
{{- end }} | ||
serviceAccountName: {{ .Values.operator.name }} | ||
{{- with .Values.operator.tolerations }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be implementing tolerations for the operator, which is only a subset of the chart, right? I tried to add tolerations myself and I'm not sure how to add tolerations to the custom resource definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure to understand: this is to schedule the operator pod itself and not the MongoDB pods with CRDs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I thought the intention was to add tolerations also to the mongoDB pods.
I've found a problem when deploying mongoDB to an ARM based environment in GCP. GCP taints their new ARM based nodes with a specific arm64 tag/label, and the only way I found to deploy pods into them was adding this toleration:
tolerations:
- key: kubernetes.io/arch
operator: Equal
value: arm64
effect: NoSchedule
Unfortunately, I haven't been able to deploy mongodb to an GCP arm64 environment because of this problem. I forked this repo and added the ability to set tolerations for the operator, and that didn't fix my issue. I tried to figure how to also add tolerations to CRDs but I didn't know how.
Should I open a different issue? Am I doing something very wrong here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try to make some time to double check the helm chart is fully functional, I didn't try on different architectures but should not be a problem.
This PR is being marked stale because it has been open for 60 days with no activity. Please update the PR or ask for a fresh review. |
Issues: #254 #308
Superseeds PR #248 (to close).
All Submissions:
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if such).Add very useful values for pod scheduling:
affinity
(moved default to values)nodeSelector
schedulerName
tolerations
topologySpreadConstraints
Sort keys alphabetically and use
with
instead ofif
when relevant.