DOCSP-43919: aggregation builder #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
force-pushed
the
DOCSP-43919-agg-builder
branch
from
a654c02 to
30da9a6
Compare
5 tasks
lindseymoore
approved these changes
Feb 10, 2025
source/aggregation.txt
Outdated
| #. Create an array to store the pipeline stages | ||
|
|
||
| #. For each stage, call an operator method from the ``Stage`` | ||
| builder class to create that type of aggregation stage |
There was a problem hiding this comment.
Suggested change
| builder class to create that type of aggregation stage | |
| builder class to create an aggregation stage of that type |
S: Optional rewording, to put emphasis on the stage
source/aggregation.txt
Outdated
Comment on lines
90
to
94
| - :ref:`php-aggregation-array-api`: Create aggregation pipelines by | ||
| passing arrays that specify the aggregation operators and parameters | ||
| - :ref:`php-aggregation-builder-api`: Create aggregation pipelines by using native |
There was a problem hiding this comment.
Q: Any guidelines on linking to sections on the same page within text and without a proper introduction? Was a little thrown off when this just led me to the section right beneath. If the team usually does this, it's alright. Could remove links if not.
rustagir
force-pushed
the
DOCSP-43919-agg-builder
branch
from
0b38fc5 to
70bcf6c
Compare
rustagir
requested review from
a team and
jmikola
and removed request for
a team
jmikola
reviewed
Feb 13, 2025
jmikola
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43919
Staging -
Self-Review Checklist