Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-46811 Standardized Logger #981

Merged
merged 8 commits into from
Feb 11, 2025

Conversation

jordan-smith721
Copy link
Collaborator

@jordan-smith721 jordan-smith721 commented Feb 7, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46811
Staging - https://deploy-preview-981--docs-node.netlify.app/fundamentals/logging/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 2a09beb
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/67abb6027751f500086c57ec
😎 Deploy Preview https://deploy-preview-981--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rustagir rustagir self-requested a review February 10, 2025 14:11
Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good start, mostly comments about organization/clarity

source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minor fixes!

source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/includes/fundamentals/logging.js Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/includes/fundamentals/logging.js Outdated Show resolved Hide resolved
source/includes/fundamentals/logging.js Outdated Show resolved Hide resolved
source/includes/fundamentals/logging.js Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
source/fundamentals/logging.txt Outdated Show resolved Hide resolved
@jordan-smith721 jordan-smith721 merged commit 630ebd2 into mongodb:master Feb 11, 2025
5 of 6 checks passed
@jordan-smith721 jordan-smith721 deleted the DOCSP-46811-logging branch February 11, 2025 21:01
github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
jordan-smith721 added a commit that referenced this pull request Feb 11, 2025
(cherry picked from commit 630ebd2)

Co-authored-by: Jordan Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants