RUST-2215 Ergonomics for HumanReadable #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
requested review from
isabelatkinson and
kevinAlbs
and removed request for
isabelatkinson
isabelatkinson
previously approved these changes
May 28, 2025
Co-authored-by: Isabel Atkinson <[email protected]>
isabelatkinson
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2215
This adds several traits to the
HumanReadablewrapper type to make it easier to work with:derive-able traits in the standard libraryrepr(transparent)(technically not a trait but close) so it doesn't cost extra memoryDisplayFromfor convenient/automatic conversionsDerefandDerefMutfor method passthroughsAsRefandAsMutfor reference conversions (so&HumanReadable<String>can be easily converted to&strfor example)