CLOUDP-297225: Add plugin telemetry tiny event #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmenezes
reviewed
Feb 13, 2025
internal/telemetry/event.go
Outdated
|
|
||
| func withEventType() EventOpt { | ||
| return func(event Event) { | ||
| event.Properties["eventType"] = "plugin" |
There was a problem hiding this comment.
discussed offline but we can't use eventtype we also tend to use snake case in properties if I'm not mistaken
cveticm
approved these changes
Feb 13, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Jira ticket: CLOUDP-297225
{2025-02-13 14:32:31.155485 +0000 GMT m=+0.007831251 atlascli map[alias:generate command:-kubernetes-config-generate eventType:plugin flags:[debug] result:SUCCESS]}]Checklist
make fmtand formatted my codeFurther comments