Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adds debug flag #35

Merged
merged 1 commit into from
Feb 13, 2025
Merged

chore: Adds debug flag #35

merged 1 commit into from
Feb 13, 2025

Conversation

cveticm
Copy link
Collaborator

@cveticm cveticm commented Feb 13, 2025

Proposed changes

plugins do not have access to global flags. This work adds debug flag to the K8s plugin.

Behaviour is as in AtlasCLI for all three commands:

image

Jira ticket: CLOUDP-300551

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in the document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@cveticm cveticm merged commit 59d53c7 into main Feb 13, 2025
12 of 13 checks passed
@cveticm cveticm deleted the CLOUDP-300551_add_debug_flag branch February 13, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeroenvervaeke jeroenvervaeke jeroenvervaeke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cveticm @jeroenvervaeke