Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Setup signing for binaries #27

Merged
merged 8 commits into from
Jan 29, 2025
Merged

ci: Setup signing for binaries #27

merged 8 commits into from
Jan 29, 2025
+105 −0

Conversation

cveticm
Copy link
Collaborator

@cveticm cveticm commented Jan 28, 2025 •
edited
Loading

Proposed changes

Adds signing to MacOS and Windows binaries.

Testing was done on macOS binaries using cosign.
Testing was done on Win binary using guide provided here on Windows VM.

Test release: v0.0.3

Jira ticket: CLOUDP-297212

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in the document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@cveticm cveticm force-pushed the CLOUDP-297212_setup_binary_signing branch from 876e8a8 to ada010d Compare January 29, 2025 10:04
@cveticm cveticm marked this pull request as ready for review January 29, 2025 10:23
andreaangiolillo
andreaangiolillo approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cveticm cveticm merged commit 0af3396 into main Jan 29, 2025
14 checks passed
@cveticm cveticm deleted the CLOUDP-297212_setup_binary_signing branch January 29, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cveticm @andreaangiolillo