ci: Setup signing packages #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibulca
reviewed
Jan 28, 2025
RELEASING.md
Outdated
Comment on lines
19
to
20
| 2. If everything goes smoothly, the release will be published in the [releases page](https://github.com/mongodb/atlas-cli-plugin-kubernetes/releases). | ||
| 3. The [evergreen](build/ci/release.yml) copybara task will automatically open a PR on docs repositories with any document changes for the docs team to review and merge. |
There was a problem hiding this comment.
renumber (3. and 4.) needed
There was a problem hiding this comment.
Good catch, done! 👍
andreaangiolillo
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
LGTM after you verified that the binaries in the GH release page (see https://www.mongodb.com/docs/atlas/cli/current/verify-packages/#verify-linux-packages)
tibulca
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds signing to all packages and includes sig public key in release.
SIgning for binaries will be done as a part of CLOUDP-297212.
Test release: https://github.com/mongodb/atlas-cli-plugin-kubernetes/releases/tag/v0.0.2
Verifying package signature for macos package:
Noting that the current key used for signatures is the atlas-cli key. This is to avoid blocking this work. A request will be made to create a new key exclusively for signing the K8s plugin and, once this key is available, necessary changes will be made to the signing process to use this new key.
Jira ticket: CLOUDP-294915
Checklist
make fmtand formatted my codeFurther comments