wallet: Improve Fee Priority Code for Clarity #9838
+279
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It built locally for me on Ubuntu, but it's failing on other distros. I'll take a look after lunch. Done: The only distro that fails now is Arch Linux and it's unrelated to my changeset. |
|
All tests pass locally. As was communicated to me (by @jeffro256 on Matrix), the test that failed here fails sporadically. |
0xFFFC0000
reviewed
Mar 18, 2025
| } | ||
|
|
||
| static FeePriority FromIntegral(const uint32_t priority) | ||
| { |
There was a problem hiding this comment.
if (req.priority > 4) {
LOG ERROR;
er.message = "Invalid priority value. Must be between 0 and 4.";
}
There was a problem hiding this comment.
Thanks, please see the commit where I add this: 41b71b9
Tzadiko
force-pushed
the
tzadiko/clean-fee-code
branch
from
69aefe5 to
41b71b9
Compare
Tzadiko
changed the title
Part of a later PR that will change the code (clean-up and change are separate).
Tzadiko
force-pushed
the
tzadiko/clean-fee-code
branch
from
bbd12c2 to
577fc9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm working on #9799 . After speaking to @nahuhh , I'd like to contribute in two steps. The first step is to clean the existing code, and then addressing the issue. This makes reviewing my changeset easier.
In this changeset there are no changes to functionality. I added fee_priority .h and .cpp. Here I added the enumeration FeePriority to replace the integer values which were confusing to understand when trying to address the original issue linked above.
I will now be looking at addressing the original issue linked, working off this 'clean up' branch.