release: drop 32-bit android target #9528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xFFFC0000
approved these changes
Oct 22, 2024
|
@nahuhh / @tobtoht maybe those binaries didn't work, but wallet_api target is what is important for mobile wallets, even if that stats are accurate that's still 1 in 10 people who wouldn't be able to run monero wallet on their phone, at least not one based on the official code. I'm strongly against removing support for something that is still supported by upstream (android still builds fine for 32bit arm, together with it still being supported target in the NDK), and something that is still being used. |
tobtoht
force-pushed
the
build_drop_32_arm_android
branch
from
a057162
to
ff0bb0f
Compare
tobtoht
changed the title
|
@MrCyjaneK I reduced the scope to official releases. Do you happen to have 32-bit ARM Android hardware? If so, could you test if the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @nahuhh these binaries haven't worked in years (see also: #8889 (comment)).
Android has mostly moved on to 64-bit: https://android.stackexchange.com/questions/253596
In a 2020 blog post ARM stated that "nearly 90 percent of today’s Android devices deploy a 64-bit capable version of the OS."
This target isn't built in depends CI.