Skip to content

Feat/set mint allowance for admin #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KristenPire
Copy link
Contributor

Summary

This PR introduces the setMintAllowanceForAdmin function, allowing a system account to set the mint allowance for an admin account using a signature provided by an admin. This function is the sole change in this PR, along with corresponding tests to ensure 100% coverage.

This function's end goal is to allow the admin to authorize actions by simply signing a message rather than submitting a full transaction. This approach ensures that the system account is the sole payer for these transactions, centralizing fee management to a single account.

Details

  • Functionality:

    • The setMintAllowanceForAdmin function enables a system account to raise the mint allowance on behalf of an admin, validated by a signature from the admin account.
    • The message to be signed by the admin is currently a static hash, allowing the function to confirm authorization based on this hardcoded message.
    • Only system accounts are permitted to call this function, and the admin providing the signature must be a recognized admin account.
  • Tests:

    • 100% test coverage is provided for the setMintAllowanceForAdmin function.
    • Tests validate correct behaviour with valid signatures, rejection of invalid signatures and admin signatures are accepted.

Impact

This change is isolated to the setMintAllowanceForAdmin function and does not add additional dependencies or modify other functions.

Future Considerations

Depending on future design decisions, the hardcoded message may be replaced with a dynamic message to allow more flexibility in message signing.

@KristenPire KristenPire self-assigned this Nov 12, 2024
@KristenPire KristenPire changed the title Feat/set mint allowance fro admin Feat/set mint allowance for admin Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant