-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/v2 xerc20 #44
Open
KristenPire
wants to merge
12
commits into
feat/v2
Choose a base branch
from
feat/v2-xERC20-timebased
base: feat/v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/v2 xerc20 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f a mint/burn timebased rate limiter (code inspired heavily by EVERCLEAR's XERC20)
… an admin can set the current and dailyLimit to. Adding new functions to reset the currentLimit to a given value regardless of the dailyLimit
…ve a cap and when trying to use more than you are allowed to
…ing or using them, to revert the IXERC20 error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the token minting and allowance system by replacing the
MintAllowanceUpgradeable
contract with a newRateLimitsUpgradeable
contract. Additionally, it includes various updates to deployment scripts and contract configurations to align with the new rate limits approach.Key Changes:
Major Contract Updates:
Rate Limits Implementation:
MintAllowanceUpgradeable
withRateLimitsUpgradeable
to manage minting and burning limits more dynamically (src/RateLimitsUpgradeable.sol
).Token
contract to useRateLimitsUpgradeable
instead ofMintAllowanceUpgradeable
(src/Token.sol
). [1] [2] [3]Contract Adjustments:
ControllerToken
,EthereumControllerToken
,GnosisControllerToken
,PolygonControllerToken
) to use_useMinterLimits
instead of_useMintAllowance
for checking minting permissions. [1] [2] [3] [4]Deployment and Configuration Scripts:
Script Updates:
configureToken.s.sol
to useLIMIT_CAP
instead ofMAX_MINT_ALLOWANCE
and added new logic for setting rate limits (script/configureToken.s.sol
). [1] [2]deployAll.sh
(script/deployAll.sh
). [1] [2]LIMIT_CAP
environment variable (script/configureToken.sh
).Batch Mint Script:
setMaxMintAllowance
andsetMintAllowance
calls in thebatchMint.s.sol
script, indicating a shift away from the old allowance system (script/batchMint.s.sol
).These changes collectively enhance the flexibility and security of the token minting process by introducing rate limits and updating the deployment scripts to support the new system.