Eliminate duplicate dates between balance periods #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest Chrome Web Store release account balance exports include duplicate dates and therefore error out when importing into Monarch. This is a critical bug fix.
Fixes #61 which is echoed by reviews on the Chrome Web Store for the latest version. The change that I made in #22 was too focused on exporting individual months, subtracting one day from the end of the period was still necessary, but only before the final period. This implementation avoids duplicate dates and to avoid regression on #22 ensures that the last day of the last period is not omitted.
P.S. GitHub is having a rough morning so I think that is why some of the checks are failing here.