Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding query and index time to options #19

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sergiodenboer
Copy link

Hi there
I was in the need of copying a portion of an index to another index for texting, while re indexing. therefore I've added such functionality to your awesome gem. Hope it suits all all needs xD.
I've also added scroll and query options to your implementations.
Please give some feedback!
Best regards!
Sérgio den Boer

@JustinAiken
Copy link
Member

I like the new options! More options are always good...

Before I merge, could you:

  • Fix the failing specs
  • Address a few in-code comments
  • Add a changelog entry?
  • Squash into a single commit

If so, I'll merge in, and push out a new release.

@sergiodenboer
Copy link
Author

Hey.
The refactoring is done. Please check for further alterations!

@JustinAiken
Copy link
Member

The refactoring is done. Please check for further alterations!

Looks a bit better now, but the tests are failing... You can see which ones on the Travis log; I'd imagine those also fail locally... Try running rake and check out the tests..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants