Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Creating a better Candy.Core.ChatRoom object #21

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

malakada
Copy link

@malakada malakada commented Jan 9, 2015

Need this to be created/finished before other PRs can be merged in.

Will require some changing of how Candy.Core handles room management, but I think it should be a lot of pretty trivial changes.


Candy.Core.ChatRoom.prototype.addRoomDom = function(chatRoomContainerSelector) {
$(chatRoomContainerSelector).append(Mustache.to_html(Candy.View.Template.Room.pane, {
roomId: self.dom.id,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces v tabs

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?! My editor is setup for 2 spaces!!

/me goes off to bring hell to sublime2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants