[Feat/#32] 폴더리스트 페이지 기능 구현 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
임시 데이터를 만들고 그 정보에 맞게 폴더라 로딩되도록 구현.
header의 선택 버튼이 활성화 되어 있는지 page와 공유되어야해서 각 페이지에 정의하도록 이동.
sewonkimm
reviewed
Jun 6, 2020
app/src/components/Header/index.tsx
Outdated
| return ( | ||
| <> | ||
| <header className={styles.header}> | ||
| <div className={styles.home_btn_div}> | ||
| <button className={styles.home_btn} type="button" /> | ||
| <button className={styles.home_btn} type="button"> | ||
| '' |
There was a problem hiding this comment.
아이콘 내부에 ' ' 글자가 표시됩니다 오타인가요?
app/src/components/Header/index.tsx
Outdated
| onClick={handleSelectBtnClick} | ||
| /> | ||
| > | ||
| '' |
Comment on lines
+47
to
+49
| {hasSaveBtn && <input type="button" className={styles.save_btn} />} | ||
| {hasLogoutBtn && <input type="button" className={styles.logout_btn} />} | ||
| {hasBackBtn && <input type="button" className={styles.back_btn} />} |
There was a problem hiding this comment.
button에서 input type="button"으로 바꾸신 이유가 있나요?
|
@sewonkimm |
header의 button이 button태그와 input태그가 혼용되고 있어 통일.
선택된 폴더의 개수가 메뉴 활성화에 영향을 미치므로 컴포넌트 위치 header에서 페이지로 이동.
JaeHyeonKim19
approved these changes
Jun 6, 2020
|
|
sewonkimm
approved these changes
Jun 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32
이 정보를 불러와서 폴더를 로딩하도록 구현.
-> 후에 비동기로 정보를 불러오도록 수정해야함.
-> 선택 후의 기능에 대해서는 구현 예정.