Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#30/add ui #31

Merged
merged 7 commits into from
May 22, 2020
Merged

Feat/#30/add ui #31

merged 7 commits into from
May 22, 2020

Conversation

sewonkimm
Copy link
Collaborator

No description provided.

@sewonkimm
[Feat] #30 Header UI 버튼 추가
a8412f2 
- image sprite 파일에 이미지 추가
- Header에icon image 모두 sprite 형식으로 불러오는 것으로 변경
- Header에 selectBtn 추가
@sewonkimm
[Feat] #30 콘텐츠 이동, 삭제 버튼 추가
40c7e3f 
- image sprite에 아이콘 추가했음
- 안쓰는 이미지 삭제했음
- FolderMore 컴포넌트를 생성해 색상 수정, 폴더 이동, 폴더 삭제 버튼을 추가했음
- MemoMore 컴포넌트를 생성해 메모 이동, 메모 삭제 버튼을 추가했음
@sewonkimm sewonkimm added this to the markup🎨 milestone May 14, 2020
soyoungjeong
soyoungjeong approved these changes May 16, 2020 •
edited
Loading
View reviewed changes
@soyoungjeong soyoungjeong self-requested a review May 16, 2020 17:09
JaeHyeonKim19
JaeHyeonKim19 requested changes May 16, 2020
View reviewed changes
Copy link
Collaborator

@JaeHyeonKim19 JaeHyeonKim19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇 가지 의문사항있어서 리뷰남겼습니다. 확인 부탁드려요.

app/src/components/FolderMore/styles.scss Outdated Show resolved Hide resolved
app/src/components/FolderMore/index.tsx Outdated Show resolved Hide resolved
app/src/components/FolderMore/styles.scss Outdated Show resolved Hide resolved
app/src/components/MemoMore/styles.scss Outdated Show resolved Hide resolved
soyoungjeong
soyoungjeong requested changes May 16, 2020
View reviewed changes
Copy link
Member

@soyoungjeong soyoungjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가로 memo edit 페이지에서는 Header에 선택 아이콘이 안나오도록 추후에 처리하는 것이 좋을 것 같네요 !

app/src/components/FolderMore/index.tsx Outdated Show resolved Hide resolved
app/src/components/Header/styles.scss Outdated Show resolved Hide resolved
@sewonkimm
[Chore] #30 rem 단위 수정
5a47992 
글꼴 크기가 바뀔 때 비율이 변하지 않도록 css사용하던 단위를 rem에서 px로 통일
@sewonkimm
[Chore] #30 class명 변경
410fbd1 
scss 코딩 컨벤션 class 네이밍 권장에 따라 class명을 camel case에서 underbar 사용으로 변경
@sewonkimm
[Chore] #30 FolderMore, MemoMore 컴포넌트명 변경
44c4cf5 
변수명의 More의 의미가 명확하지 않아 Setting으로 변경
@sewonkimm
Copy link
Collaborator Author

sewonkimm commented May 21, 2020 •
edited
Loading

UI 디자인에 대한 의견을 반영 #34

@sewonkimm
Copy link
Collaborator Author

MemoEdit 페이지에 저장버튼 추가 #36

@sewonkimm
[Chore] #30 UI 수정사항 반영
7d79c4d 
1. Foler Setting, Memo Setting 페이지의 디자인 변경에 따른 수정사항 반영
2. 버튼 삭제후 이미지형 아이콘으로 통일
3. image sprite에 이미지 추가
@sewonkimm
[Chore] #36 save 버튼 추가
12b66ff
JaeHyeonKim19
JaeHyeonKim19 approved these changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@JaeHyeonKim19 JaeHyeonKim19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요👍

@sewonkimm sewonkimm merged commit 1bc43e0 into develop May 22, 2020
@sewonkimm sewonkimm deleted the feat/#30/addUI branch May 22, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaeHyeonKim19 JaeHyeonKim19 JaeHyeonKim19 approved these changes

@soyoungjeong soyoungjeong soyoungjeong approved these changes

Assignees

@sewonkimm sewonkimm

Labels
front-end👀 markup🎨
Projects
None yet
Milestone
markup🎨
Development

Successfully merging this pull request may close these issues.
3 participants
@sewonkimm @soyoungjeong @JaeHyeonKim19