Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MemoEditPage 에 저장 버튼 추가 #36

Open
2 of 4 tasks
sewonkimm opened this issue May 17, 2020 · 0 comments
Open
2 of 4 tasks

MemoEditPage 에 저장 버튼 추가 #36

sewonkimm opened this issue May 17, 2020 · 0 comments
Assignees
@sewonkimm

Comments

@sewonkimm
Copy link
Collaborator

sewonkimm commented May 17, 2020 •
edited
Loading

  • figma 수정
  • header에 저장버튼 추가
  • 뒤로가기 했을 때 pop up ( 저장하지 않고 나가시겠습니까? )
  • 저장 폴더 설정 버튼 삭제 ( MemoListPage에서 이동할 수 있으므로 )
@sewonkimm sewonkimm self-assigned this May 17, 2020
@sewonkimm sewonkimm mentioned this issue May 21, 2020
Merged
sewonkimm added a commit that referenced this issue May 21, 2020
@sewonkimm
[Chore] #36 save 버튼 추가
12b66ff
sewonkimm added a commit that referenced this issue May 23, 2020
@sewonkimm
[feat] #36 header button을 url에 따라 조정
0189975 
props에 path 값을 전달해 보내서 url에 맞는 버튼만 보이도록 렌더링
sewonkimm added a commit that referenced this issue May 23, 2020
@sewonkimm
Merge branch 'develop' of https://github.com/mojimojicorp/MojimojiMemoji
4376668 
 into feat/#36/header
sewonkimm added a commit that referenced this issue May 24, 2020
@sewonkimm
[Refact] #36 header button loading
64a4e04 
1. 화면이 2번 렌더링 되는 것을 줄이기 위해 useEffect 제거
2. 가독성을 향상하기 위해 state 사용을 제거하고 props로 값을 넘겨주는
방식으로 구조를 변경
sewonkimm added a commit that referenced this issue May 31, 2020
@sewonkimm
Merge pull request #39 from mojimojicorp/feat/#36/header
4caf8bf 
[feat] #36 header button을 url에 따라 조정
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sewonkimm sewonkimm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sewonkimm