Use S3 to upload feedback images #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hugozap
commented
Nov 23, 2022
hugozap
commented
- Create s3 bucket.
- Lambda that generates an upload url for s3
- Endpoint that calls previous lambda to return the upload URL to clients.
hugozap
changed the title
zahiruldu
reviewed
Nov 24, 2022
Comment on lines
+16
to
+18
| Key: `${uuid.v4()}.jpeg`, | ||
| ContentType: "image/jpeg", | ||
| }; |
There was a problem hiding this comment.
Are we confirmed about the file type will be always jpeg?
zahiruldu
reviewed
Nov 24, 2022
| @@ -36,3 +30,28 @@ export function getLambdaApiSaveFeedback( | |||
| ...props, | |||
| }); | |||
| } | |||
|
|
|||
| export function getUploadImageLambda( | |||
| scope: Construct, | |||
There was a problem hiding this comment.
Do we need any test coverage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.