This repository has been archived by the owner on Aug 3, 2024. It is now read-only.
Rewrite cosmetics and theme preferences #1733
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brawaru
force-pushed
the
feat/theme-cosmetics-rewrite
branch
from
80f11e1
to
cfa34f7
Compare
brawaru
changed the title
brawaru
commented
Jun 16, 2024
Comment on lines
+376
to
+378
| 'Accept-CH': 'Sec-CH-Prefers-Color-Scheme', | ||
| Vary: 'Sec-CH-Prefers-Color-Scheme', | ||
| 'Critical-CH': 'Sec-CH-Prefers-Color-Scheme', |
There was a problem hiding this comment.
More information about this header here: https://wicg.github.io/user-preference-media-features-headers/#sec-ch-prefers-color-scheme.
brawaru
force-pushed
the
feat/theme-cosmetics-rewrite
branch
from
cfa34f7
to
dcaf16f
Compare
- Cosmetics and theme preferences are now only stored in cookies instead of mix of both the cookies and the state. - Theme preference now supports client hints. This means the server can render the page in correct theme for the client if the client passes that information (any browser other than Firefox), which avoids annoying flash. - Hacky Nitro plugin for theme has been removed. It's functionality should be fully provided by the theme plugin with much cleaner code that uses Nuxt's built-ins. - All pages and components should be updated to use the new plugins.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmetics and theme preferences are now only stored in cookies instead of mix of both the cookies and the state.
Theme preference now supports client hints. This means the server can render the page in correct theme for the client if the client passes that information (any browser other than Firefox), which avoids annoying flash.
Hacky Nitro plugin for theme has been removed. It's functionality should be fully provided by the theme plugin with much cleaner code that uses Nuxt's built-ins.
All pages and components should be updated to use the new plugins.