[Feat] Map 컴포넌트 및 테스트 코드 구현 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moida ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for moida-ui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
devpla
approved these changes
Oct 3, 2022
| } | ||
| }, [latitude, longitude, level]) | ||
|
|
||
| return <MapContainer id="map" /> |
There was a problem hiding this comment.
외부 api를 사용할 때,
- class로 구현하거나
- method들을 리턴하는 훅으로 구현하는 경우를 종종 본 것 같아요.
고도화되면 사용해보고 피드백 남겨볼게요!
There was a problem hiding this comment.
네 좋아요! 저도 커스텀훅을 개인적으로 시도해봤어요
그 과정에서 설계에 대한 논의가 필요하다고 느꼈어요
| "file-loader": "^6.2.0", | ||
| "next": "12.2.5", | ||
| "react": "18.2.0", | ||
| "react-dom": "18.2.0", | ||
| "recoil": "^0.7.5", |
There was a problem hiding this comment.
쿼리랑 리코일을 도입했군요! 모이다 본격적으로 시작이라는 느낌이 드네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈
📝 설명
📷 스크린샷