-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
recipient_thread_close via Buttons #3363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
martinbndr
wants to merge
11
commits into
modmail-dev:development
from
martinbndr:update_recipient_thread_close
Closed
recipient_thread_close via Buttons #3363
martinbndr
wants to merge
11
commits into
modmail-dev:development
from
martinbndr:update_recipient_thread_close
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martinbndr
commented
Feb 27, 2025
- Updates the recipient_thread_close feature to use a button instead of a reaction.
- New config options: recipient_thread_close_button_label, recipient_thread_close_button_style
- The close_emoji default value is now None to make it possible changing the button to only have a label.
Merge Development
Signed-off-by: Taku <[email protected]>
Implements a checking mechanismen for local git repository.
Update check git
This fixes some incorrect help text of the thread_close_response and thread_self_close_response
- Updates the recipient_thread_close feature to use a button instead of a reaction. - New config options: recipient_thread_close_button_label, recipient_thread_close_button_style - The close_emoji default value is now None to make it possible changing the button to only have a label.
recipient_thread_close via Buttons
recipient_thread_close via Buttons
Oh no I think I messed up with the commits to actually only include the required one for the update |
Will recreate it to have only correct commits in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.