-
Notifications
You must be signed in to change notification settings - Fork 903
[docs] update vllm deploy DP docs #6139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] update vllm deploy DP docs #6139
Conversation
Summary of ChangesHello @Jintao-Huang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the clarity and utility of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation for vLLM deployment with data parallelism and adds a corresponding example script. I've found a couple of minor issues: one is a suggestion to improve the clarity of the documentation, and the other two are related to a new example script, which contains a typo in the JSON payload and is missing a final newline character.
- 🔥vllm_tensor_parallel_size: Tensor parallelism size. Default is `1`. | ||
- vllm_pipeline_parallel_size: Pipeline parallelism size. Default is `1`. | ||
- vllm_data_parallel_size: Data parallelism size, default is 1, effective in the infer and rollout commands. | ||
- vllm_data_parallel_size: the number of data parallelism (dp) instances, default is `1`, effective in the `swift deploy/rollout` command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrasing "the number of data parallelism (dp) instances" is a bit verbose and less standard than the previous "Data parallelism size". I suggest rephrasing for better clarity and consistency with common terminology.
- vllm_data_parallel_size: the number of data parallelism (dp) instances, default is `1`, effective in the `swift deploy/rollout` command. | |
- vllm_data_parallel_size: Data parallelism size (DP), default is `1`, effective in the `swift deploy/rollout` command. |
# ]}], | ||
# "max_tokens": 256, | ||
# "temperature": 0 | ||
# }' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the documentation and adds an example for using data parallelism (DP) with vLLM for deployment. The changes accurately reflect that vllm_data_parallel_size
is now supported in swift deploy
. I've provided a couple of suggestions to improve the clarity of the documentation and the new example script. Overall, these are good improvements.
- 🔥vllm_tensor_parallel_size: Tensor parallelism size. Default is `1`. | ||
- vllm_pipeline_parallel_size: Pipeline parallelism size. Default is `1`. | ||
- vllm_data_parallel_size: Data parallelism size, default is 1, effective in the infer and rollout commands. | ||
- vllm_data_parallel_size: Data parallelism size, default is `1`, effective in the `swift deploy/rollout` command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better clarity and conciseness, consider rephrasing this line. The current wording is a bit verbose.
- vllm_data_parallel_size: Data parallelism size, default is `1`, effective in the `swift deploy/rollout` command. | |
- vllm_data_parallel_size: Number of data parallelism (DP) replicas. Default is `1`, effective in the `swift deploy/rollout` command. |
#6114