-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine/llm api op unittest #528
Open
BeachWang
wants to merge
178
commits into
main
Choose a base branch
from
refine/llm_api_op_unittest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ev/llm_info_extract
…ev/llm_info_extract
# Conflicts: # data_juicer/config/config.py # data_juicer/core/analyzer.py
…into dev/manage_meta
BeachWang
added
enhancement
New feature or request
dj:core
issues/PRs about the core functions of Data-Juicer
labels
Jan 3, 2025
HYLcool
reviewed
Jan 9, 2025
@@ -13,6 +13,8 @@ np: 4 # number of subproce | |||
text_keys: 'text' # the key name of field where the sample texts to be processed, e.g., `text`, `instruction`, `output`, ... | |||
# Note: currently, we support specify only ONE key for each op, for cases requiring multiple keys, users can specify the op multiple times. We will only use the first key of `text_keys` when you set multiple keys. | |||
suffixes: [] # the suffix of files that will be read. For example: '.txt', 'txt' or ['txt', '.pdf', 'docx'] | |||
turbo: false # Enable Turbo mode to maximize processing speed when batch size is 1. | |||
skip_op_error: true # Skip errors in OPs caused by unexpected unvalid samples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unvalid --> invalid
HYLcool
reviewed
Jan 9, 2025
'--skip_op_error', | ||
type=bool, | ||
default=True, | ||
help='Skip errors in OPs caused by unexpected unvalid samples.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip_op_error
param to enable fault-tolerant when execute DataJuiceranalyzer
andexecutor
, but disable fault-tolerant for unit test.