Support Progress Flow for McpServer #300
Conversation
|
This is really awesome pr! I really hope this one merged as soon as possible! |
|
Force-pushed with resolving conflict. |
BREAKING : Client Specification record is braking
|
Force-pushed with resolving conflict, again. |
|
@134130 thank you for trying to fill this missing capabilities. But because the progress tracking introduces a breaking changes to the existing API and goes beyond the tool calling, or server side only, I've updated the #298 issue, listing the required task to implement this capability. |
| @@ -139,6 +139,16 @@ public Mono<McpSchema.ListRootsResult> listRoots(String cursor) { | |||
| LIST_ROOTS_RESULT_TYPE_REF); | |||
| } | |||
|
|
|||
| public Mono<Void> notification(String method, Object params) { | |||
There was a problem hiding this comment.
This is too generic. We would need something like progress(ProgressNotificaiton pn) instead.
There was a problem hiding this comment.
I thought restricting the method to only “progress” would block users until the SDK releases a new protocol adaptation, and it did in some cases: loggingNotification(LoggingMessageNotification loggingMessageNotification).
I agree there is also progress(ProgressNotification pn) should be exists.
Also, there might have users that who want to send custom notifications to.
There was a problem hiding this comment.
fixed with a specific method, but please consider keeping the general one too.
|
Thanks! I'll follow up after those PRs are merged. |
…Notification to send client progress updates
because of the client code is restored for PR seperation
|
Updated the Code and PR Description and separated Client implementation PR. |
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context