-
Notifications
You must be signed in to change notification settings - Fork 299
support auth by HTTP basic auth #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lambochen
wants to merge
7
commits into
modelcontextprotocol:main
Choose a base branch
from
lambochen:feature/auth_by_params
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
support auth by HTTP basic auth #205
lambochen
wants to merge
7
commits into
modelcontextprotocol:main
from
lambochen:feature/auth_by_params
+253
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lambochen <[email protected]>
Signed-off-by: lambochen <[email protected]>
Signed-off-by: lambochen <[email protected]>
Signed-off-by: lambochen <[email protected]>
related issue: #204 |
CC: @tzolov thx |
Signed-off-by: lambochen <[email protected]>
Signed-off-by: lambochen <[email protected]>
related Spring AI |
Signed-off-by: lambochen <[email protected]>
McpServerAuthProvider exampleMcpServerAuthProvider implement example import io.modelcontextprotocol.server.McpServerAuthParam;
import io.modelcontextprotocol.server.McpServerAuthProvider;
// import org.springframework.stereotype.Component;
// @Component
public class CustomMcpServerAuthProvider implements McpServerAuthProvider {
@Override
public boolean authenticate(McpServerAuthParam param) {
// example: get token param
String token = param.getParams().get("token");
// TODO do something
return true;
}
} MCP Client(eg: Claude) config {
"mcpServers": {
"mcp-remote-server-example": {
"url": "http://{your mcp server}/sse?token=xxx"
}
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Support a way to auth client-server connection by request params.
I think it's necessary, such as, When using Claude Desktop to connect to a remote MCP Server, only one URL can be filled in. If identity authentication and authorization are implemented, passing information from the request parameters is a good choice.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context