Skip to content

support auth by HTTP basic auth #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lambochen
Copy link

@lambochen lambochen commented Apr 25, 2025

Motivation and Context

Support a way to auth client-server connection by request params.
I think it's necessary, such as, When using Claude Desktop to connect to a remote MCP Server, only one URL can be filled in. If identity authentication and authorization are implemented, passing information from the request parameters is a good choice.

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@lambochen
Copy link
Author

related issue: #204

@lambochen
Copy link
Author

CC: @tzolov thx

Signed-off-by: lambochen <[email protected]>
@lambochen
Copy link
Author

related Spring AI
Issue: spring-projects/spring-ai#2888
PR: spring-projects/spring-ai#2886

Signed-off-by: lambochen <[email protected]>
@lambochen
Copy link
Author

McpServerAuthProvider example

McpServerAuthProvider implement example

import io.modelcontextprotocol.server.McpServerAuthParam;
import io.modelcontextprotocol.server.McpServerAuthProvider;
// import org.springframework.stereotype.Component;

// @Component
public class CustomMcpServerAuthProvider implements McpServerAuthProvider {

	@Override
	public boolean authenticate(McpServerAuthParam param) {
		// example: get token param
		String token = param.getParams().get("token");
		// TODO do something
		return true;
	}

}

MCP Client(eg: Claude) config

{
  "mcpServers": {
    "mcp-remote-server-example": {
      "url": "http://{your mcp server}/sse?token=xxx"
    }
  }
}

@lambochen lambochen changed the title support auth by request params support auth by HTTP basic auth Apr 28, 2025
@lambochen lambochen marked this pull request as draft April 28, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant