Fix STDIO server restart issue and add comprehensive tests #760
+715
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves issue #654 where STDIO servers with lifespan contexts failed to restart after disconnection. ## Problem STDIO servers with lifespan contexts couldn't restart after disconnect because: - Transport references remained in global Maps after disconnect - Stale SSEServerTransport instances tried to send through closed connections - Resulted in "Not connected" errors and ERR_CONNECTION_REFUSED on reconnect ## Solution - Added optional onCleanup callback to mcpProxy function - Modified server routes to provide cleanup functions that remove transport references - Ensures webAppTransports and serverTransports Maps are cleaned up properly - Cleanup triggers when either client or server transports close ## Tests Added - Unit tests for mcpProxy function covering message forwarding, error handling, and cleanup - Integration tests simulating real-world STDIO server restart scenarios - Tests demonstrate both the original bug and the fix 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Ola Hungerford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #654
This PR resolves the issue where STDIO servers with lifespan contexts fail to restart after disconnection.
Problem
STDIO servers with lifespan contexts couldn't restart after disconnect because:
Solution
Tests Added
Testing
This fix should resolve the restart issues for servers using lifespan contexts while maintaining compatibility with existing transport types.
Generated with Claude Code