fix: use original Error object for uncaught errors when provided in browser #5080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
958 (which is closed but not really fixed)🐛 Bug: Browser doesn't include call stack for global uncaught errors #5106status: accepting prs
Overview
In case of uncaught errors, mocha would print only the error message, which is essentially the first line of the stack trace. The actual stack trace was unused. This is essentially #2403 which was closed for inactivity.
Here's a fiddle demonstrating the problem: https://jsfiddle.net/Lru1q4n6/ (updated from the PR above). Unfortunately, I don't know how to demonstrate the fix there. Of course it does work locally, I used this fix to debug our tests.
Co-authored-by: @mgiuffrida