Forward DNS requests into --internal networks #47821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmry
added
status/2-code-review
area/networking
impact/changelog
kind/bugfix
robmry
commented
May 10, 2024
robmry
force-pushed
the
internal_network_with_dns
branch
2 times, most recently
from
af621b5
to
b27e52b
Compare
cpuguy83
reviewed
May 10, 2024
| Source: fname, | ||
| Target: "/etc/dnsd.conf", | ||
| }), | ||
| container.WithCmd("dnsd"), |
A recent change to prevent containers only connected to --internal networks from communicating with external DNS servers inadvertently prevented the daemon's internal DNS server from forwarding requests within an internal network to a containerised DNS server. Relax the check, so that only requests that need to be forwarded from the host's network namespace are dropped. External DNS servers remain unreachable from the internal network. Signed-off-by: Rob Murray <[email protected]>
robmry
force-pushed
the
internal_network_with_dns
branch
from
b27e52b
to
77a47db
Compare
akerouanton
approved these changes
May 13, 2024
vvoland
approved these changes
May 14, 2024
|
I went ahead and created a backport to have this attached to the 26.1.3 milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixes #47822
#47538 prevents containers only connected to
--internalnetworks from communicating with external DNS servers - it also inadvertently prevents the daemon's internal DNS server from forwarding requests within an internal network to a containerised DNS server.- How I did it
Relax the check, so that only requests that need to be forwarded from the host's network namespace are dropped.
External DNS servers remain unreachable from the internal network.
- How to verify it
New integration test.
- Description for the changelog