[WIP, DNM] try using oci.Platform where possible #42606
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Jul 7, 2021
api/types/types.go
Outdated
Comment on lines
41
to
45
| Architecture string | ||
| Variant string `json:",omitempty"` | ||
| Os string | ||
| OsVersion string `json:",omitempty"` | ||
| Size int64 |
There was a problem hiding this comment.
Need to think of this one, as this will have different output in JSON (Architecture => architecture, OsVersion -> os.version, Variant -> variant).
The "capitalised" vs "lowercase" changes should not be a problem when (un)marshalling, as Golang handles these case-insensitive, but OsVersion -> os.version will (likely) be an issue.
thaJeztah
force-pushed
the
use_oci_platform
branch
7 times, most recently
from
4410cf0
to
3c4498a
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
use_oci_platform
branch
from
3c4498a
to
78050d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slightly related to #42464. Wondering if replacing these custom fields with the oci.Platform type would work