exporter: fix reporting push progress under export vertex#6587
Merged
tonistiigi merged 1 commit intomoby:masterfrom Mar 20, 2026
Merged
exporter: fix reporting push progress under export vertex#6587tonistiigi merged 1 commit intomoby:masterfrom
tonistiigi merged 1 commit intomoby:masterfrom
Conversation
Wrap finalize calls in inBuilderContext with the same vertex ID used during export, so push status (layers and manifest) appears under the "exporting to image" vertex in the progress stream instead of being reported without a parent context. This broke when pushing was moved to be parallel step after main export phase. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
9d74c49 to
b333547
Compare
crazy-max
approved these changes
Mar 17, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap finalize calls in inBuilderContext with the same vertex ID used during export, so push status (layers and manifest) appears under the "exporting to image" vertex in the progress stream instead of being reported without a parent context.
This broke when pushing was moved to be parallel step after main export phase.
@amrmahdi