v0.12: Fix tests for Moby v25 compatibility#6547
Open
Shubhranshu153 wants to merge 1 commit intomoby:v0.12from
Open
v0.12: Fix tests for Moby v25 compatibility#6547Shubhranshu153 wants to merge 1 commit intomoby:v0.12from
Shubhranshu153 wants to merge 1 commit intomoby:v0.12from
Conversation
Shubhranshu153
force-pushed
the
fix-v0.12-for-moby-25
branch
from
01faaba to
fbb996e
Compare
tonistiigi
reviewed
Mar 3, 2026
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
Just remove the test. We already dropped support for this in server side with containerdv2 https://github.com/moby/buildkit/blob/master/util/imageutil/config.go#L118
tonistiigi
reviewed
Mar 3, 2026
Shubhranshu153
force-pushed
the
fix-v0.12-for-moby-25
branch
from
fbb996e to
d17ea67
Compare
- Deprecate testSchema1Image: gcr.io no longer supports Schema1 manifests This changes ensure buildkit v0.12 tests pass with Moby v25. Signed-off-by: Shubhranshu Mahapatra <shubhum@amazon.com>
Shubhranshu153
force-pushed
the
fix-v0.12-for-moby-25
branch
from
d17ea67 to
91b4523
Compare
Author
|
@tonistiigi Can i get review for this. Fixed the changes. |
tonistiigi
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes ensure buildkit v0.12 tests pass with Moby v25.
Related PR: moby/moby#52027