This repository has been archived by the owner on Jul 10, 2020. It is now read-only.
Refactoring to use Map to build chart options and data. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….Map because elemental don't support a function or raw js object in JsonValue. Implemented userCallback in Ticks.
|
I appreciate your effort but It would have been nice if you first discussed your planned changes here rather than changing half of code base. Anyway I'll try to review it on the weekend. |
|
@moberwasserlechner, you are right, I think a lot before start to do this modification, it is really impact in all codebase. But, after try many times to make it works with elemental (because I need to pass a JS function to chart) I only found this solution. |
…lback" is documented).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop to work with elemental json lib and start to use plain java.util.Map because elemental don't support a function or raw js object in JsonValue.
Implemented userCallback in Ticks.
#39
#38 (initial work)