Skip to content
This repository has been archived by the owner on Apr 26, 2023. It is now read-only.

Play 2.7 support #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Play 2.7 support #34

wants to merge 1 commit into from

Conversation

akovbovich
Copy link

No description provided.

Copy link

@almothafar almothafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR I hope it will work well.

sbt.version=1.1.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 1.2.x I think, as play 2.7 supports 1.2.7+

@@ -1 +1 @@
version in ThisBuild := "0.2.0"
version in ThisBuild := "0.3.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to add more info in README.md as well.

@cfoster
Copy link

cfoster commented Jun 7, 2019

On running

sbt clean package

I'm getting

[error] /private/tmp/sbt-play-gulp/play-gulp/app/com/github/mmizutani/playgulp/GulpAssets.scala:108:57: Cannot find any HTTP Request Header here
[error]           Forbidden(views.html.defaultpages.unauthorized())
[error]                                                         ^
[info] Formatting 2 Scala sources in sbt-play-gulp:compile ...
[error] one error found
[info] Compiling 2 Scala sources to /private/tmp/sbt-play-gulp/sbt-play-gulp/target/scala-2.12/sbt-1.0/classes ...
[info] Done compiling.
[info] Packaging /private/tmp/sbt-play-gulp/sbt-play-gulp/target/scala-2.12/sbt-1.0/sbt-play-gulp-0.3.0.jar ...
[info] Done packaging.
[error] (play-gulp / Compile / compileIncremental) Compilation failed
[error] Total time: 7 s, completed 06-Jun-2019 20:24:44

You may need to change line 108 of
play-gulp/app/com/github/mmizutani/playgulp/GulpAssets.scala

to:

Forbidden(views.html.defaultpages.unauthorized()(request))

This gets it to compile for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants