Use example formatting in placeholders. Labels++ #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update labels w/descriptions, instead of placeholder fields.
mmcardle
requested changes
Jul 8, 2023
GeoMaciolek
commented
Jul 28, 2023
mmcardle
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update labels w/descriptions, instead of placeholder fields. This includes:
Changes
CamelCase / CapNames for Models
e.g.
Personnotperson,LibraryBooknotlibrary_bookorlibrarybookThis is the norm, per:
app_name with underscores
This is the norm in general as well, examples provided if needed!
attribute_names with underscores
e.g.
first_namenotfirstnameetc. - all I did here was make the placeholder a bit more obvious. Examples also provided on request.Reasoning
The placeholder text
amodelled me to create a project with models likeaudio_fileandauthorinstead ofAudioFileandAuthor. In theory I should have known better, but, I let my GUI-brain treat the hints literally. Whoops! I figured I wouldn't be the only person who ended up having to do a bunch of ultimately unneccesary refactoring and find/replace work, so, here's what should hopefully help!