Don't generate entries for Abstract Models in more areas (Fixes #194) #197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Hope the multiple edits here isn't too messy - if need be, we can roll it up into one.)
Regarding Issue #194 - the fixes pushed a few days ago in 0e1ef96 didn't handle all of the issues, so I've replicated the ``filter(model => !model.abstract)` in a few other generators:
api_py()
urls_py()
index_htm()
htmx_htm()
serializers()
All of those seem correct to me. The one I'm less certain about is a change around line 216 in
rendering.js
- I'm not sure howconst apps
is used. This might break stuff, or it might not. My testing didn't indicate any issues, but I don't have the whole test harness working - I mostly did it by hand, so, not all code paths for sure. Help & testing would be appreciated!