feat: add support for 7z files #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McPatate
force-pushed
the
feat/add_7z_scan
branch
2 times, most recently
from
e5ffd8b to
7508413
Compare
mmaitre314
requested changes
Feb 8, 2025
McPatate
force-pushed
the
feat/add_7z_scan
branch
from
c9e8521 to
6d9b079
Compare
McPatate
force-pushed
the
feat/add_7z_scan
branch
from
6d9b079 to
5f05e99
Compare
McPatate
commented
Feb 12, 2025
mmaitre314
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had repos that used 7z to compress their malicious models. Adding support for that in this PR.
Open to suggestions on code, not too pleased with the way I had to do it. AFAICT there is no way to get a byte stream for a specific file within the archive with
py7zr(cfSevenZipFile.extractdocs).Not sure pytorch or others support loading from 7z files, but as we've had people store things in them I'd rather have the extra feature than not.