ignore ssh-agent, ssh-keygen utf-8 decode failures #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my environment I have a smart card (PKCS11) that holds my private keys; for reasons I cannot change the comment field includes bytes that cannot be decoded into `utf-8`. The comment field is useful but not essential for the SSM API call `SendSSHPublicKey`. This PR sets the `bytes.decode()` calls to to ignore any `utf-8` decoding errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my environment I have a smart card (PKCS11) that holds my private keys; for reasons I cannot change the comment field includes bytes that cannot be decoded into
utf-8.The comment field is useful but not essential for the SSM API call
SendSSHPublicKey. This PR sets thebytes.decode()calls to to ignore anyutf-8decoding errors.