fix: remove defaults in params that are not in base R or imports

mlr-org · Dec 21, 2024 · 43f9a11 · 43f9a11
1 parent f2d07f6
commit 43f9a11
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,8 @@
 # mlr3cluster (development version)
 
+* fix: Mclust learner no longer sets the control default with a function not in
+  import to stay compliant with {paradox} conventions
+
 # mlr3cluster 0.1.10
 
 * Add BIRCH learner from 'stream' package

diff --git a/R/LearnerClustMclust.R b/R/LearnerClustMclust.R
@@ -26,7 +26,7 @@ LearnerClustMclust = R6Class("LearnerClustMclust",
         G = p_uty(default = 1:9, tags = "train", custom_check = check_numeric),
         modelNames = p_uty(tags = "train", custom_check = check_character),
         prior = p_uty(tags = "train", custom_check = check_list),
-        control = p_uty(default = mclust::emControl(), tags = "train", custom_check = check_list),
+        control = p_uty(tags = "train", custom_check = check_list),
         initialization = p_uty(tags = "train", custom_check = check_list),
         x = p_uty(tags = "train", custom_check = crate(function(x) check_class(x, "mclustBIC")))
       )