Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build macOS app and extend the README.md regarding macOS release #181

Merged
merged 4 commits into from
Mar 18, 2024

Conversation

Ecostack
Copy link
Contributor

@Ecostack Ecostack commented Mar 13, 2024

  • The macOS app is now properly packaged as a .app file
  • The readme has been extended

One thing to mention here is that unsigned apps can have trouble being executed if downloaded. I described this in the README. Ultimately, if you are interested in having a distribution without these signing issues, an Apple developer account is necessary.

This one contains a couple of more changes, please let me know if you want things changed.

Screenshot 2024-03-13 at 10 39 14

@mlange-42
Copy link
Owner

Using .zip instead of .tar.gz is certainly good for accessibility by people not using Linux.

However, I am not really happy with the MacOS instructions being like the longest section of the README 😆.
Maybe we can instead link to some external docs that provide this information?

Also took a brief look at how to sign the app. Look like it requires XCode, which requires MacOS (or another Apple OS). Great...

@Ecostack
Copy link
Contributor Author

Yeah, regarding .zip, I think we can also do the same thing for the Windows build.

I can fully understand that this is a bit out of place maybe. Maybe we have a separate macOS file for that?

As for the signing the app, we could do that during the GitHub action build process. The macOS variant is already using macOS instances instead of the Ubuntu instances.
It would be up to you if you want to embark on the journey of getting a developer account. IMO, it is not required right now. It might be just awkward if the user does not know about how to open it without signature.

@mlange-42
Copy link
Owner

I can fully understand that this is a bit out of place maybe. Maybe we have a separate macOS file for that?

Or maybe even move all information on using and building locally to a separate page? It could then also be linked from the itch.io download section.

@mlange-42 mlange-42 added the infrastructure CI, tests, publishing, ... label Mar 13, 2024
@Ecostack
Copy link
Contributor Author

To clarify, this PR only gets merged if the parts regarding the README are changed or are you waiting on shortly before the next release?

@mlange-42
Copy link
Owner

I would prefer to move the MacOS / general local usage/"installation" stuff to INSTALL.md or so. Also, it would be great if you could change to .zip for windows builds.

Besides that, this can be merged.

@mlange-42
Copy link
Owner

@Ecostack Thank you!

@mlange-42 mlange-42 merged commit 481891e into mlange-42:main Mar 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure CI, tests, publishing, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants