Add optional props for setting minDays, maxDays, dateRange #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional props - minDays: minimum number of days that must be selected. If the date range selected is less than minDays specified then the amount of days selected will be automatically increased. - maxDays: maximum number of days that can be selected. If the date range exceeds the number of maxDays specified then the amount of days selected will be automatically reduced. - dateRange: different from initialDateRange as this is a contolled value
|
Awesome! 🎉 Just a small suggestion: since |
|
@miyushan It is used in the PR. dateRange had been local state in the useDateRangePicker hook which I renamed internalDateRange in support of minDays and maxDays. You can see on line 65 now the dateRange prop is destructured to {startDate, endDate} if dateRange exists otherwise internalDateRange is destructured |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional props
date range selected is less than minDays specified then the
amount of days selected will be automatically increased.
date range exceeds the number of maxDays specified then the
amount of days selected will be automatically reduced.