Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sitemapamic.php #14

Closed
wants to merge 1 commit into from
Closed

Conversation

johannitsa
Copy link

This is just a pull request seeking to explore if this feature would be accepted into the main repository.

Basically, the idea is to exclude pages marked as "noindex" from the SEO Pro Addon.

Furthermore, we can have this option configurable if the feature is to be accepted.

Exclude pages marked as noindex via SEO Pro addon
@martyf
Copy link
Contributor

martyf commented Jul 23, 2023

I'm not an SEO Pro user myself, so won't want to really put code that uses a specific add-on in. I'd like to steer away from this sort of opinionation given there are a few different SEO addons that people use (or just use fields)

However, in saying that, is it possible to get the noindex value directly?

Another idea I have is to maybe add a callback functionality that can help with filtering so that this logic can be in one of your app's service providers.

That might be the cleaner approach, if you think that would still be helpful?

@martyf
Copy link
Contributor

martyf commented Jul 17, 2024

Try upgrading to 3.1.0 and see how the computed configuration can work. Does this solve the issue for you?
https://docs.mity.com.au/sitemapamic/configuration/computed-configuration

@martyf
Copy link
Contributor

martyf commented Oct 3, 2024

Closed due to inactivity.

@martyf martyf closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants