Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import urlparse for python 3 #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iamsalnikov
Copy link

When I try to run my script with that code:

from flask_oauth import OAuth


oauth = OAuth()

then I get this error:

Traceback (most recent call last):
  File "web_server.py", line 1, in <module>
    from web import app
  File "/path/web/__init__.py", line 5, in <module>
    from web import auth
  File "/path/web/auth.py", line 6, in <module>
    from web.oauth import twitter
  File "/path/oauth.py", line 1, in <module>
    from flask_oauth import OAuth
  File "/path/vendor/lib/python3.4/site-packages/flask_oauth.py", line 14, in <module>
    from urlparse import urljoin
ImportError: No module named 'urlparse'

In python 3.4 module urlparse became urllib.parse. In this pull request I try to fix this.

@rembish
Copy link

rembish commented Oct 27, 2015

+1

@rachtsingh
Copy link

Just wrote the same before checking the pull requests. This is the only dependency failure right now for porting my Flask app.

+1

@tcyrus
Copy link

tcyrus commented Apr 28, 2016

Duplicate of #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants