Ingest sloan courses via api #1487
Open
+365
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/ol_orchestrate/resources/openedx.py
blarghmatey
reviewed
Feb 25, 2025
Comment on lines
111
to
127
| def get_sloan_courses(self): | ||
| """ | ||
| Retrieve the course data from their API as JSON | ||
| returns: JSON document representing an array of course objects | ||
| """ | ||
| course_url = "https://mit-unified-portal-prod-78eeds.43d8q2.usa-e2.cloudhub.io/api/courses" | ||
| return self._fetch_with_auth(course_url) | ||
|
|
||
| def get_sloan_course_offerings(self): | ||
| """ | ||
| Retrieve the course offerings data from their API as JSON | ||
| returns: JSON document representing an array of course offering objects | ||
| """ | ||
| course_offering_url = "https://mit-unified-portal-prod-78eeds.43d8q2.usa-e2.cloudhub.io/api/course-offerings" | ||
| return self._fetch_with_auth(course_offering_url) |
There was a problem hiding this comment.
These method seem like they're unnecessary in this context. If we wanted to make a Sloan API specific resource we could put them there, but I think it's easy enough to just use the fetch_with_auth and pass the URL in question. Another reason to not have these methods here is that they will then be inherited by the edX resource (which won't break anything, but is a leaky abstraction)
There was a problem hiding this comment.
Yes, I realized that they don't belong here. I moved them to the asset file so we don't need to create a new resource file for these two simple methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/6687
Description (What does it do?)
Creating new dagster code location, definition, and assets for learning resources such as Sloan courses.
Also, creating a new OAuthApiClient resource that is not tied to the edx instance, and modifying OpenEdxApiClient to inherit from it
How can this be tested?
export GITHUB_TOKEN=
docker compose up
Go to http://127.0.0.1:3000/locations/ol_orchestrate.definitions.learning_resource.extract_api_data/assets, ensure 2 assets listed.
Click on Materialize for the two assets
The existing assets that use OpenEdxApiClient should still work. This could be tested by materializing any of http://127.0.0.1:3000/locations/ol_orchestrate.definitions.edx.retrieve_edxorg_raw_data/assets