Skip to content

Commit

Permalink
formatting
Browse files Browse the repository at this point in the history
  • Loading branch information
mbertrand committed Mar 19, 2024
1 parent 000635c commit f3a6e12
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
4 changes: 3 additions & 1 deletion ui/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ def get_moira_client(retries=settings.MOIRA_RETRIES):
)
for idx in range(retries):
try:
return Moira(settings.MIT_WS_CERTIFICATE_FILE, settings.MIT_WS_PRIVATE_KEY_FILE)
return Moira(
settings.MIT_WS_CERTIFICATE_FILE, settings.MIT_WS_PRIVATE_KEY_FILE
)
except Exception as exc: # pylint: disable=broad-except
if idx == retries - 1:
raise MoiraException(
Expand Down
10 changes: 5 additions & 5 deletions ui/utils_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,16 @@ def test_get_moira_client_success(mock_moira, settings):
settings.MIT_WS_CERTIFICATE_FILE, settings.MIT_WS_PRIVATE_KEY_FILE
)

@pytest.mark.parametrize("retries, raise_error", [
[3, False],
[2, True]
])

@pytest.mark.parametrize("retries, raise_error", [[3, False], [2, True]])
def test_get_moira_client_retries(settings, mocker, retries, raise_error):
"""Test that the expected # retries are made to get a moira client"""
tempfile1, tempfile2 = (NamedTemporaryFile(), NamedTemporaryFile())
settings.MIT_WS_PRIVATE_KEY_FILE = tempfile1.name
settings.MIT_WS_CERTIFICATE_FILE = tempfile2.name
mocked_moira = mocker.patch("ui.utils.Moira", side_effect=[Exception, Exception, Mock()])
mocked_moira = mocker.patch(
"ui.utils.Moira", side_effect=[Exception, Exception, Mock()]
)
if raise_error:
with pytest.raises(MoiraException):
get_moira_client(retries=retries)
Expand Down

0 comments on commit f3a6e12

Please sign in to comment.