Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to django 3.2 #196

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Upgrade to django 3.2 #196

merged 1 commit into from
Nov 11, 2021

Conversation

umarmughal824
Copy link
Contributor

@umarmughal824 umarmughal824 commented Sep 15, 2021

Pre-Flight checklist

  • Testing
    • Code is tested
    • Changes have been manually tested

What are the relevant tickets?

fixes #101

What's this PR do?

Upgrade to django 3.2

How should this be manually tested?

Just check that everything is still functional and up

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2021

Codecov Report

Merging #196 (1e9af19) into main (3cd5dfb) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head 1e9af19 differs from pull request most recent head b0fd223. Consider uploading reports for the commit b0fd223 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
- Coverage   91.14%   90.95%   -0.20%     
==========================================
  Files         218      214       -4     
  Lines        6462     6279     -183     
  Branches      318      307      -11     
==========================================
- Hits         5890     5711     -179     
+ Misses        485      481       -4     
  Partials       87       87              
Impacted Files Coverage Δ
main/apps.py 100.00% <100.00%> (+100.00%) ⬆️
main/settings.py 93.68% <100.00%> (+0.03%) ⬆️
openedx/api.py 78.16% <0.00%> (-5.75%) ⬇️
fixtures/common.py 70.58% <0.00%> (-2.95%) ⬇️
main/sentry.py 58.82% <0.00%> (-2.29%) ⬇️
courses/api.py 85.13% <0.00%> (-1.70%) ⬇️
static/js/lib/notificationsApi.js 75.00% <0.00%> (-1.48%) ⬇️
cms/models.py 71.42% <0.00%> (-0.67%) ⬇️
courses/views/v1/__init__.py 97.18% <0.00%> (-0.65%) ⬇️
users/serializers.py 94.48% <0.00%> (-0.36%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd5dfb...b0fd223. Read the comment docs.

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get my eyes on a warning regarding the default auto field for our models which came from Django 3.2 migration.

Although it's a warning, I think we should fix it by defining DEFAULT_AUTO_FIELD in our settings to resolve the it. Attaching the reference below:

Screenshot 2021-09-22 at 4 13 47 PM

@umarmughal824
Copy link
Contributor Author

I was able to get my eyes on a warning regarding the default auto field for our models which came from Django 3.2 migration.

Although it's a warning, I think we should fix it by defining DEFAULT_AUTO_FIELD in our settings to resolve the it. Attaching the reference below:

Screenshot 2021-09-22 at 4 13 47 PM

@arslanashraf7 thank's for pointing it out. It didn't go through my eyes that's why got skipped.

@umarmughal824
Copy link
Contributor Author

The build is failing because of missing migrations in robots and social_django for which I have create a couple of open source PR's
python-social-auth/social-app-django#354
jazzband/django-robots#112

@umarmughal824
Copy link
Contributor Author

@arslanashraf7 that's ready for review again.

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good.

@umarmughal824 umarmughal824 merged commit 970cb97 into main Nov 11, 2021
@umarmughal824 umarmughal824 deleted the umar/online-101 branch November 11, 2021 12:04
@odlbot odlbot mentioned this pull request Nov 15, 2021
4 tasks
@odlbot odlbot mentioned this pull request Nov 17, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to django 3.2
3 participants