Skip to content

Proposal: Always add "Home / Module Index / Search" button #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Proposal: Always add "Home / Module Index / Search" button #252

wants to merge 1 commit into from

Conversation

jstriebel
Copy link
Contributor

It would be great to have a button leading to the top-level index-page in lower-nested pages by default. Not sure what would be the nicest way visually, I just added a simple text button, but also a home or search-magnification icon could be used, maybe even without any text.

Screenshot from 2021-04-22 14-18-28

A simple icon without text would also prevent more line-breaks:
Screenshot from 2021-04-22 14-18-59

I'm sorry if this proposal is too specific, I just thought it might be useful in the default templates.

@jstriebel
Copy link
Contributor Author

Having a search bar as proposed in #23 would be even nicer and supersede this.

@mhils
Copy link
Member

mhils commented Apr 22, 2021

Thanks for raising this! How would you feel about a permanent Module Index button replacing the "go one layer up" button on submodules? Maybe that's the more useful button in general.

@jstriebel
Copy link
Contributor Author

Thanks for raising this! How would you feel about a permanent Module Index button replacing the "go one layer up" button on submodules? Maybe that's the more useful button in general.

Good idea, I think that's more useful. However, I'm not sure if I'd expect to go to the index-page with the search or the modules documentation. Maybe buttons for both? E.g. I'd actually expect https://pdoc.dev/docs/pdoc.html to be the "home" page (or Module Index), but https://pdoc.dev/docs/ provides the search and should be accessible from everywhere (until there's a search bar).

@mhils
Copy link
Member

mhils commented Apr 22, 2021

Good idea, I think that's more useful. However, I'm not sure if I'd expect to go to the index-page with the search or the modules documentation.

Ah, yes. That's a very good point to make. Thanks!

Given the circumstances I'd lean towards keeping the current setup We will eventually add a search bar that does things proper, until then I'm inclined not to introduce temporary stopgaps. :)

Thank you anyhow for the PR. I hope you don't mind keeping that around in your local config. 😃

@mhils mhils closed this Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants